refactor(root): extract auth exemption logic#2
Merged
masnwilliams merged 1 commit intomainfrom Aug 20, 2025
Merged
Conversation
There was a problem hiding this comment.
Performed full review of d579cf8...d34c5d9
1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored and extracted authentication exemption logic in the root command to allow
helpandcompletioncommands to run without requiring authentication.Why we made these changes
To improve the robustness and clarity of authentication bypass logic for non-sensitive commands like
helpand shellcompletion, enhancing user experience by allowing these fundamental functions to operate without login.What changed?
cmd/root.go:isAuthExempthelper function.PersistentPreRunEhook to leverageisAuthExemptfor determining authentication bypass for commands likehelpandcompletion.Description generated by Mesa. Update settings